Store exceptions in request env#994
Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom Mar 21, 2017
Merged
Conversation
Contributor
Author
|
For reference, this is the Rollbar middleware I have in mind: https://github.com/rollbar/rollbar-gem/blob/master/lib/rollbar/middleware/rails/rollbar.rb#L26-L28 This is also what the |
travisofthenorth
force-pushed
the
store-exceptions
branch
from
f336014 to
ae71cab
Compare
|
I think this is a great PR. 👍 |
Contributor
|
@travisofthenorth Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that there is an exception whitelist, and that all exceptions can be whitelisted in the latest version with the
whitelist_all_exceptionsconfiguration. IMO, this is tangential issue, because as a developer, I might want the gem to handle an exception for me as far as responding to users with error messages, but I also want this exception to be logged separately.For example, I rely on a Rollbar middleware to report exceptions for alerting/monitoring of my services. Because the gem was swallowing exceptions (in this case a database timeout, which should absolutely sound the alarms), I wasn't aware of a critical app error. Again, I still want the gem to handle responding to users with error messages, but I want those server errors to be processed by the rest of my middleware chain.